fix(python-sdk): temporarily remove async types #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested.
- Reviewed the entire pull request up to 34ec344
- Looked at
155lines of code in7files - Took 2 minutes and 23 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
1additional comments because they didn't meet confidence threshold of50%.
1. /sdks/python/julep/managers/utils.py:42:
- Assessed confidence :
100% - Grade:
0% - Comment:
The print statement in the 'sync_wrapper' function is a debug statement and should be removed from the production code. - Reasoning:
The print statement in the 'sync_wrapper' function in 'utils.py' is a debug statement and should not be part of the production code. It can potentially leak sensitive information in the logs.
Workflow ID: wflow_jryM1KCaJGoIvQcY
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. We'll respond in a few minutes. Learn more here.
creatorrr
reviewed
Apr 16, 2024
philipbalbas
force-pushed
the
f/sdk-python-async-types
branch
from
3e20081 to
84540cb
Compare
There was a problem hiding this comment.
👍 Looks good to me!
- Performed an incremental review on 84540cb
- Looked at
72lines of code in3files - Took 1 minute and 6 seconds to review
More info
- Skipped
1files when reviewing. - Skipped posting
1additional comments because they didn't meet confidence threshold of50%.
1. /sdks/python/pyproject.toml:20:
- Assessed confidence :
50% - Comment:
The version ofpytypehas been downgraded in the dev dependencies. Please ensure that this does not remove any necessary features or fixes that were present in the newer version. - Reasoning:
The PR author has downgraded the version of pytype in the dev dependencies. This could potentially introduce issues if the newer version of pytype was being used to leverage features or fixes that are not present in the older version. It's important to understand the reason behind this downgrade.
Workflow ID: wflow_EWQyRIqclG9a5fLk
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR involves code cleanup and formatting changes, including the removal of async types, reformatting of certain fields, removal of a debug print statement, and a change in
pytypeversion inpyproject.toml.Key points:
agent.py,doc.py,session.py,user.py.httpx_clientinclient.py.utils.py.logit_biasfield inchat_settings.py.pytypeversion inpyproject.toml.Generated with ❤️ by ellipsis.dev